Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the loaders of the plagiarism runner #805

Merged
merged 3 commits into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@libre-man
Copy link
Collaborator

libre-man commented Feb 18, 2019

Description

This also fixes a race condition that occurred when the runs were loaded before the plagiarism providers, as the providers are needed for displaying the runs.

Merge the loaders of the plagiarism runner
This also fixes a race condition that occurred when the runs were loaded before
the plagiarism providers, as the providers are needed for displaying the runs.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #805 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #805   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          57       57           
  Lines        5535     5535           
=======================================
  Hits         5501     5501           
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfca9b...db05473. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #805 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #805   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          57       57           
  Lines        5535     5535           
=======================================
  Hits         5501     5501           
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfca9b...0c42357. Read the comment docs.

@olmokramer olmokramer merged commit 96ad4b4 into master Feb 19, 2019

7 checks passed

codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 27% (0.0% change)
Details
codecov/patch Coverage not affected when comparing ccfca9b...0c42357
Details
codecov/project 99.38% remains the same compared to ccfca9b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@olmokramer olmokramer deleted the bugfix/merge-loaders-plagiarism-runner branch Feb 19, 2019

@wafflebot wafflebot bot removed the in progress label Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.