Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite submission page #87

Merged
merged 15 commits into from Aug 24, 2017

Conversation

Projects
None yet
3 participants
@olmokramer
Copy link
Collaborator

commented Jul 14, 2017

Description

Closes #83 and additionally solves other issues with the submission navbar that caused a lot of API requests.

Includes #115

  • There's still a race condition that sometimes causes the submission file not to be displayed. I don't know why this happens
@@ -14,24 +14,24 @@
<b-collapse is-nav id="nav_collapse">
<div v-if="loggedIn" class="nav-container justify-content-md-between">
<b-nav is-nav-bar>
<b-nav-item @click.stop>
<b-nav-item>

This comment has been minimized.

Copy link
@Skydivizer

Skydivizer Jul 16, 2017

Contributor

The @click.stop raises an error, but something in the default handler of b-nav-item prevents ctrl + click from opening the link in a new tab.

It turns out when router-link is used that you don't require the nested router-link element. You can just add the to and active-class (and other router-link props) to the nav-item element. In this construct ctrl + click also seems to work correctly.

Thus this should be something like this:

<b-nav-item :to="{ name: 'me', params: { userId: this.userid, }, }" active-class="active">
    {{username}}
</b-nav-item>

This comment has been minimized.

Copy link
@olmokramer

olmokramer Jul 17, 2017

Author Collaborator

Ok, awesome! I've changed it.

olmokramer added some commits Jul 17, 2017

Remove `<router-link>`s from the navbar component
the `<b-nav-item>`s provide the same functionality
@Skydivizer
Copy link
Contributor

left a comment

Looks good!

},
clicked(val) {
goToSubmission(submissionId) {
console.log(submissionId);

This comment has been minimized.

Copy link
@Skydivizer

Skydivizer Jul 19, 2017

Contributor

Please remove.

@olmokramer olmokramer changed the title Rewrite submission navbar WIP: Rewrite submission page Jul 19, 2017

@olmokramer olmokramer changed the title WIP: Rewrite submission page Rewrite submission page Jul 19, 2017

olmokramer added some commits Jul 19, 2017

@libre-man

This comment has been minimized.

Copy link
Collaborator

commented Jul 20, 2017

Is this mergeable?

olmokramer added some commits Aug 24, 2017

Fix file uploader for Firefox
It was broken because Firefox requires the `method` and `enctype` to be
set on a `<form>` element. This also fixes an unrelated error on the
submissions page.

Fixes #113

olmokramer and others added some commits Aug 24, 2017

@libre-man
Copy link
Collaborator

left a comment

Awesome, nice work!

Changes were made.

@libre-man libre-man merged commit a781106 into master Aug 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 87.973%
Details

@olmokramer olmokramer deleted the rewrite-submission-navbar branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.