Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border when CodeGrade is loaded in an iframe in Canvas #883

Merged
merged 9 commits into from Apr 3, 2019

Conversation

@olmokramer
Copy link
Collaborator

commented Mar 28, 2019

This happens only in Canvas.

Closes #871

@ghost ghost assigned olmokramer Mar 28, 2019

@ghost ghost added the in progress label Mar 28, 2019

@olmokramer olmokramer changed the title Add border when CodeGrade is loaded in an iframe Add border when CodeGrade is loaded in an iframe in Canvas Mar 28, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 29, 2019

Codecov Report

Merging #883 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #883   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          57       57           
  Lines        5856     5856           
=======================================
  Hits         5824     5824           
  Misses         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367756e...a28fa49. Read the comment docs.

src/App.vue Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved

We haven't tested this in a live Canvas (and other LMSs) instance yet.

@ghost ghost assigned libre-man Apr 3, 2019

libre-man and others added 2 commits Apr 3, 2019

@ghost ghost assigned yourivoet Apr 3, 2019

@yourivoet

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Tested in live canvas and blackboard instances.

@yourivoet yourivoet merged commit 5c63976 into master Apr 3, 2019

6 of 8 checks passed

codeclimate 2 issues to fix
Details
codeclimate/diff-coverage 0% (50% threshold)
Details
codeclimate/total-coverage 27%
Details
codecov/patch Coverage not affected when comparing 367756e...a28fa49
Details
codecov/project 99.45% remains the same compared to 367756e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.454%
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@yourivoet yourivoet deleted the tweak/add-border-in-lti branch Apr 3, 2019

@ghost ghost removed the in progress label Apr 3, 2019

olmokramer added a commit that referenced this pull request Apr 4, 2019
Merge pull request #899 from CodeGra-de/master
# Version 1.5.x (Izanami.2)

**Released**: April 04th, 2019

You can now set up detailed hand-in requirements for your students, create course snippets and the submission page is easier to and has more information (including the possibility to upload multiple files).

## Features & Updates

- Add a new version of the ignore file [(#889)](#889): this makes it possible to set detail hand-in requirements for students.
- Allow uploading multiple files [(#888)](#888): students can now upload multiple files and archives.
- Add course snippets [(#897)](#897): course snippets are shared between all teachers and ta's of a course.
- Add Moodle support [(#873)](#873): full LTI integration with Moodle.
- Add Blackboard support [(#820)](#820): full LTI integration with Blackboard.
- Enhance documentation [(#875)](#875): better documentation which includes user guides.
- Rewrite submission list page header [(#885)](#885): more information, including a better visible rubric for students.

## Minor updates

- Edit snippets in modal [(#855)](#855): a better UI for adding snippets.
- Add border when CodeGrade is loaded in an iframe in Canvas [(#883)](#883): this makes it more clear where CodeGrade begins and Canvas ends.
- White background for sidebar when not in dark theme [(#865)](#865): this makes the light mode more beautiful.
- Improve the way rubric maximum points are presented [(#895)](#895): added warnings and improved the UI, so the feature is not misused.
- Make it possible to filter submissions by member of the group [(#840)](#840).
- Increase the default value used for minimal similarity for jplag [(#894)](#894): changed it from 25 to 50, making sure users don't get too much cases by default.
- Add multiple file uploader to documentation [(#896)](#896).
- Update documentation to apply to new snippet management UI [(#891)](#891).
- Improve filtering the course users [(#893)](#893): increased the efficiency of the filtering.

## Fixes

- Make sure duplicate filenames are detected and renamed [(#898)](#898).
- Show when user has no snippets [(#890)](#890).
- Set default deadline time to 23:59 [(#879)](#879).
- Fix new tab button position in sidebar [(#867)](#867).
- Fix home page logo position [(#851)](#851).
- Fix header text color in dark theme [(#852)](#852).
- Fix file tree resizer z-index [(#853)](#853).
- Rename "Old password" to "Current password" [(#856)](#856).
olmokramer added a commit that referenced this pull request Apr 4, 2019
Merge pull request #899 from CodeGra-de/master
**Released**: April 04th, 2019

You can now set up detailed hand-in requirements for your students, create course snippets and the submission page is easier to and has more information (including the possibility to upload multiple files).

- Add a new version of the ignore file [(#889)](#889): this makes it possible to set detail hand-in requirements for students.
- Allow uploading multiple files [(#888)](#888): students can now upload multiple files and archives.
- Add course snippets [(#897)](#897): course snippets are shared between all teachers and ta's of a course.
- Add Moodle support [(#873)](#873): full LTI integration with Moodle.
- Add Blackboard support [(#820)](#820): full LTI integration with Blackboard.
- Enhance documentation [(#875)](#875): better documentation which includes user guides.
- Rewrite submission list page header [(#885)](#885): more information, including a better visible rubric for students.

- Edit snippets in modal [(#855)](#855): a better UI for adding snippets.
- Add border when CodeGrade is loaded in an iframe in Canvas [(#883)](#883): this makes it more clear where CodeGrade begins and Canvas ends.
- White background for sidebar when not in dark theme [(#865)](#865): this makes the light mode more beautiful.
- Improve the way rubric maximum points are presented [(#895)](#895): added warnings and improved the UI, so the feature is not misused.
- Make it possible to filter submissions by member of the group [(#840)](#840).
- Increase the default value used for minimal similarity for jplag [(#894)](#894): changed it from 25 to 50, making sure users don't get too much cases by default.
- Add multiple file uploader to documentation [(#896)](#896).
- Update documentation to apply to new snippet management UI [(#891)](#891).
- Improve filtering the course users [(#893)](#893): increased the efficiency of the filtering.

- Make sure duplicate filenames are detected and renamed [(#898)](#898).
- Show when user has no snippets [(#890)](#890).
- Set default deadline time to 23:59 [(#879)](#879).
- Fix new tab button position in sidebar [(#867)](#867).
- Fix home page logo position [(#851)](#851).
- Fix header text color in dark theme [(#852)](#852).
- Fix file tree resizer z-index [(#853)](#853).
- Rename "Old password" to "Current password" [(#856)](#856).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.