Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure duplicates work better #35

Merged
merged 18 commits into from Feb 13, 2019

Conversation

@libre-man
Copy link
Contributor

commented Dec 3, 2018

No description provided.

@olmokramer
Copy link
Contributor

left a comment

Much better!

):
end = 4
if len(dups) != len(set(d['created_at'][:4] for d in dups)):
end = None

This comment has been minimized.

Copy link
@olmokramer

olmokramer Jan 28, 2019

Contributor

Maybe we should still remove the time portion of the name? end = 10?

This comment has been minimized.

Copy link
@libre-man

libre-man Jan 30, 2019

Author Contributor

Yeah that is probably a good idea.

This comment has been minimized.

Copy link
@libre-man

libre-man Jan 30, 2019

Author Contributor

That might however not be possible, if the created date is very close to each other. This is a rare case so personally I'm fine with doing it this way.

assignments, lambda x: x['name']
):
for dup in dups:
dup['name'] += ' - ' + dup['created_at']

This comment has been minimized.

Copy link
@olmokramer

olmokramer Jan 28, 2019

Contributor

Same as above. Should we also do that for submissions in an assignment? Probably not remove the hours and minutes, maybe not even the seconds, but everything after that can be removed IMO.

This comment has been minimized.

Copy link
@libre-man

libre-man Jan 30, 2019

Author Contributor

Agree, the seconds are also useless imo.

libre-man added some commits Feb 7, 2019

@libre-man libre-man force-pushed the bugfix/fix-duplicates branch from 854dad2 to 4adcd26 Feb 7, 2019

libre-man added some commits Feb 7, 2019

@libre-man libre-man force-pushed the bugfix/fix-duplicates branch 3 times, most recently from 123f991 to 1a4ecc2 Feb 7, 2019

@libre-man libre-man force-pushed the bugfix/fix-duplicates branch from 1a4ecc2 to 587c2e3 Feb 7, 2019

@libre-man libre-man force-pushed the bugfix/fix-duplicates branch from 36441df to 4552cca Feb 7, 2019

libre-man added some commits Feb 7, 2019

@libre-man libre-man force-pushed the bugfix/fix-duplicates branch from 79e7b92 to 485c986 Feb 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 7, 2019

Codecov Report

Merging #35 into master will decrease coverage by 0.34%.
The diff coverage is 88.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   90.05%   89.71%   -0.35%     
==========================================
  Files           6        6              
  Lines        1539     1575      +36     
==========================================
+ Hits         1386     1413      +27     
- Misses        153      162       +9
Impacted Files Coverage Δ
codegra_fs/cgfs.py 91% <100%> (+0.54%) ⬆️
codegra_fs/cgapi.py 92.55% <64.7%> (-2.54%) ⬇️
codegra_fs/utils.py 54.16% <92.85%> (+15.93%) ⬆️
codegra_fs/cgfs_types.py 11.11% <0%> (-88.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3756a4...16788cd. Read the comment docs.

@libre-man libre-man force-pushed the bugfix/fix-duplicates branch 3 times, most recently from 3331ba9 to 9cac6a6 Feb 7, 2019

@libre-man libre-man force-pushed the bugfix/fix-duplicates branch from 9cac6a6 to 3280c71 Feb 7, 2019

@libre-man libre-man force-pushed the bugfix/fix-duplicates branch from 170cb55 to 686f96c Feb 7, 2019

libre-man added some commits Feb 7, 2019

@libre-man libre-man force-pushed the bugfix/fix-duplicates branch from b8a9c17 to 1ea13d2 Feb 7, 2019

libre-man added some commits Feb 7, 2019

@libre-man libre-man force-pushed the bugfix/fix-duplicates branch from 0ff4703 to 16788cd Feb 7, 2019

@olmokramer olmokramer merged commit c5b564d into master Feb 13, 2019

1 of 3 checks passed

codecov/patch 88.52% of diff hit (target 90.05%)
Details
codecov/project 89.71% (-0.35%) compared to c3756a4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@olmokramer olmokramer deleted the bugfix/fix-duplicates branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.