New dock ami #573
Merged
New dock ami #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible/dock.yml
Outdated
| - include: image-builder.yml git_branch="{{ image_builder_version }}" | ||
| - include: krain.yml git_branch="{{ krain_version }}" | ||
| - include: charon.yml git_branch="v4.0.0" | ||
| - include: dock-init.yml git_branch="new-dock-init" |
There was a problem hiding this comment.
remember to update this to right tag before we push to prod!
| become: true | ||
| command: docker pull registry.runnable.com/runnable/image-builder:v4.2.2 | ||
|
|
||
| - name: pulling swarm |
There was a problem hiding this comment.
also pull weave please, find version in ansible
Author
There was a problem hiding this comment.
anandkumarpatel
approved these changes
Nov 23, 2016
| become: true | ||
| command: docker pull registry.runnable.com/runnable/image-builder:v4.2.2 | ||
|
|
||
| - name: pulling swarm |
| - include: dock-init.yml git_branch="new-dock-init" | ||
| - include: krain.yml git_branch="v0.3.0" | ||
|
|
||
| - hosts: "{{ host }}" |
There was a problem hiding this comment.
that does this do? where is host set?
Author
There was a problem hiding this comment.
I think because we need to execute the next block w/ the roles I used the hosts part to specify a new block. there is probably a better way to do this
|
This is good to go! |
anandkumarpatel
requested changes
Nov 23, 2016
| dest: /etc/hosts | ||
| insertafter: EOF | ||
| block: | | ||
| 10.4.4.82 registry.runnable.com |
There was a problem hiding this comment.
make this a var, also remove from dock-init if needed
| become: true | ||
| command: docker pull swarm:1.2.5 | ||
|
|
||
| - name: pulling registry |
There was a problem hiding this comment.
there are sooo many of these now, lets cleanup?
- name: pulling images
become: true
command: docker pull {{ item }}
with_items:
- "registry:2.3.1"
- "google/cadvisor:v0.24.1"
... list out all images like this instead
anandkumarpatel
approved these changes
Nov 23, 2016
henrymollman
force-pushed
the
new-dock-ami
branch
from
79e8d45 to
a644b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates docker image pull tasks to the standard dock.yml playbook, adds amazon ssm-agent to an ami and fixes a (recently introduced) bug related to parsing strings and the ansible unarchiver.