New dock init #41
Merged
New dock init #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
November 4, 2016 14:04
|
Deployed |
henrymollman
force-pushed
the
new-dock-init
branch
from
6b61731 to
32588a7
Compare
anandkumarpatel
requested changes
Nov 22, 2016
lib/container.sh
Outdated
|
|
||
| # swarm should be started last so we know everything is up | ||
| backoff container::_start_swarm_container | ||
| docker ps | awk '/swarm/ { print $1 }' | xargs docker restart |
| fi | ||
|
|
||
| if [ -z "${CONSUL_HOSTNAME+x}" ]; then | ||
| export CONSUL_HOSTNAME=10.4.5.144 |
Contributor
There was a problem hiding this comment.
a bit dangerous having a rando IP here
Contributor
Author
There was a problem hiding this comment.
agreed but hopefully another value will be supplied
henrymollman
force-pushed
the
new-dock-init
branch
from
0371c2f to
32588a7
Compare
anandkumarpatel
requested changes
Nov 23, 2016
| container::_start_cadvisor_container::called | ||
| container::_start_node_exporter_container::called | ||
| container::_start_swarm_container::called | ||
| upstart::start_docker::called |
Contributor
There was a problem hiding this comment.
missing upstart::start_docker::restore below
lib/container.sh
Outdated
| container::_start_cadvisor_container() { | ||
| local name="google/cadvisor" | ||
| local version="v0.24.1" | ||
| local version="$(consul::get ${name}/version)" |
Contributor
There was a problem hiding this comment.
I say lets still hard code these... since only specific version will be baked into the ami
anandkumarpatel
approved these changes
Nov 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be used along with the new dock init changes in devops-scripts/ansible to launch an instance into a dock pool better...faster...stronger