30 validate codesamples #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 20, 2014 18:36
the context of the sample is missing
them with more info(md filename, code sample number). Created some more mock files.
| @@ -5,6 +5,18 @@ def self.run_test_for_file(file_name) | |||
| kramdown_doc = MarkdownLoader.load_file(file_name) | |||
| #pulling an array of codespans/code samples from markdown document | |||
| code_samples = Traverser.codespans(kramdown_doc) | |||
|
|
|||
| code_samples = code_samples.map do |sample| | |||
| p sample | |||
There was a problem hiding this comment.
Is the debug output here on purpose? If not, then it should be removed :)
|
solves issues #30 |
| return [:warning, code_sample] | ||
| end | ||
|
|
||
| before_match = code_sample.match(/(.*) #=>/) |
|
Nice |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
created TestConverter and AtaruError