Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

30 validate codesamples #38

Merged
merged 9 commits into from Sep 1, 2014
Merged

30 validate codesamples #38

merged 9 commits into from Sep 1, 2014

Conversation

@madziaf
Copy link
Contributor

madziaf commented Sep 1, 2014

created TestConverter and AtaruError

@madziaf

This comment has been minimized.

Copy link
Contributor

madziaf commented on test/test_converter_test.rb in abbf3ce Aug 27, 2014

Here is an issue to discuss. If the code stays that way, the user will get from the test runner (minitest) the error message, that 'a' in not known.
Do we want the test runner to throw an error, or should there be a warning from ataru before?
related to #30

them with more info(md filename, code sample number). Created some more mock files.
@@ -5,6 +5,18 @@ def self.run_test_for_file(file_name)
kramdown_doc = MarkdownLoader.load_file(file_name)
#pulling an array of codespans/code samples from markdown document
code_samples = Traverser.codespans(kramdown_doc)

code_samples = code_samples.map do |sample|
p sample

This comment has been minimized.

Copy link
@schultyy

schultyy Sep 1, 2014

Is the debug output here on purpose? If not, then it should be removed :)

nanoparsec pushed a commit that referenced this pull request Sep 1, 2014
30 validate codesamples
@nanoparsec nanoparsec merged commit 55cba48 into master Sep 1, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@nanoparsec
Copy link
Member

nanoparsec commented Sep 1, 2014

solves issues #30

@nanoparsec nanoparsec deleted the 30-validate-codesamples branch Sep 1, 2014
return [:warning, code_sample]
end

before_match = code_sample.match(/(.*) #=>/)

This comment has been minimized.

Copy link
@moonglum
@moonglum
Copy link

moonglum commented Sep 2, 2014

Nice 👍

@nanoparsec nanoparsec mentioned this pull request Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.