Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Explicitly name jQuery in Node require() call for browserify support #95

Merged
merged 1 commit into from Jun 30, 2013

Conversation

Projects
None yet
2 participants
Contributor

00dani commented Jun 21, 2013

browserify can't properly handle require()s with expressions inside, and since require(deps[0]) only ever comes out as require('jquery') in Toastr there's no particular reason not to put the jQuery identifier in the code directly. Having done this, browserify can detect the jQuery dependency and bundle jQuery with Toastr (as is required to have Toastr work).

johnpapa added a commit that referenced this pull request Jun 30, 2013

Merge pull request #95 from 00Davo/browserify-require
Explicitly name jQuery in Node require() call for browserify support

@johnpapa johnpapa merged commit f837a40 into CodeSeven:master Jun 30, 2013

smh added a commit to smh/toastr that referenced this pull request Oct 23, 2013

Adding back in support for browserify.
Commit 29fcfcb reverted the changes
from pull request #95 (uninenttionally?). This adds back in the
browserify support.

smh added a commit to smh/toastr that referenced this pull request Oct 23, 2013

Adding back in support for browserify.
Commit 29fcfcb reverted the changes
from pull request #95 (unintentionally?). This adds the browserify
support back in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment