Let append and prepend be set to null without throwing an exception #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
the
$append/$prependproperties are alreadynullable, however when you set them tonullthrough the setter methods it triggers theInvalidArgumentException.I would not consider this expected behaviour, especially when passing a
Closure(which is allowed) that conditionally appends or prepends an item based on a condition, like user permissions.By adding a single clause that does nothing if
nullis passed in (or if$prepend/$appendevaluate tonull), expected behaviour is restored.Let me know if there is a reason it should behave like this, thank you.