Feat: add default-variable fallback when override-resolved artifact URL fails#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates artifact URL resolution to retry with package default variables when the override-resolved URL is invalid, unresolved, or unavailable. If the default-based URL resolves successfully, Composer installs from that URL; if it also fails, behavior falls back to the existing Composer dist/source path.
Motivation and Context
Consumers can provide override variables that resolve to a non-existent artifact variant even when the package default variant exists and is valid for the same platform. Previously, that scenario could drop directly to base Composer fallback behavior. This change improves resilience by attempting a sensible in-plugin fallback first (defaults +
{version}), so users are more likely to get a usable platform artifact without manual intervention.What's Changed
Breaking Changes
None.