From 2bb3788123cf1e2940443a73bc823ad579afa47d Mon Sep 17 00:00:00 2001 From: khalidbih Date: Sun, 19 Apr 2026 01:22:46 +0100 Subject: [PATCH 1/2] fix complete book library debugging and HTML validation fixes --- debugging/book-library/index.html | 35 +++++------- debugging/book-library/script.js | 89 ++++++++++++++++--------------- 2 files changed, 58 insertions(+), 66 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..d366f3c7 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,12 +1,10 @@ - - + - - + My Book Library + + + + @@ -14,7 +12,7 @@ rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" /> - + @@ -31,7 +29,7 @@

Library

Library /> Library />Read Library - - - - - - - - - + - - + diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..a5572631 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -2,13 +2,12 @@ let myLibrary = []; window.addEventListener("load", function (e) { populateStorage(); - render(); }); function populateStorage() { if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( + const book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); + const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", "127", @@ -20,27 +19,38 @@ function populateStorage() { } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const readCheckbox = document.getElementById("check"); //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { + const trimmedTitle = titleInput.value.trim(); + const trimmedAuthor = authorInput.value.trim(); + + const trimmedPages = Number(pagesInput.value); + + if (!trimmedTitle || !trimmedAuthor || !trimmedPages) { alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); + return; } + const book = new Book( + trimmedTitle, + trimmedAuthor, + trimmedPages, + readCheckbox.checked + ); + + myLibrary.push(book); + + titleInput.value = ""; + authorInput.value = ""; + pagesInput.value = ""; + readCheckbox.checked = false; + + render(); } function Book(title, author, pages, check) { @@ -51,37 +61,30 @@ function Book(title, author, pages, check) { } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; + const table = document.getElementById("display"); + const rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } //insert updated row and cells let length = myLibrary.length; for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); + const row = table.insertRow(1); + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); titleCell.innerHTML = myLibrary[i].title; authorCell.innerHTML = myLibrary[i].author; pagesCell.innerHTML = myLibrary[i].pages; //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; + const changeBut = document.createElement("button"); changeBut.className = "btn btn-success"; + changeBut.innerHTML = myLibrary[i].check ? "yes" : "No"; wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; changeBut.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; @@ -89,15 +92,15 @@ function render() { }); //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + const delButton = document.createElement("button"); + deleteCell.appendChild(delButton); + delButton.className = "btn btn-warning"; + delButton.innerHTML = "Delete"; + delButton.addEventListener("click", function () { + const deletedBook = myLibrary[i]; myLibrary.splice(i, 1); render(); + alert(`You've deleted title: ${deletedBook.title}`); }); } } From 8719e9ac642500bbb056175a0caf606dc168de12 Mon Sep 17 00:00:00 2001 From: khalidbih Date: Mon, 20 Apr 2026 01:29:31 +0100 Subject: [PATCH 2/2] use tbody, cleaner DOM rendering, improved text handling --- debugging/book-library/index.html | 7 ++-- debugging/book-library/script.js | 70 ++++++++++++++++++------------- 2 files changed, 44 insertions(+), 33 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index d366f3c7..eab6067e 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,8 +1,9 @@ - + + + My Book Library - @@ -81,5 +82,5 @@

Library

- + diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index a5572631..8a737108 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,4 +1,9 @@ -let myLibrary = []; +const myLibrary = []; + +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const readCheckbox = document.getElementById("check"); window.addEventListener("load", function (e) { populateStorage(); @@ -6,11 +11,11 @@ window.addEventListener("load", function (e) { function populateStorage() { if (myLibrary.length == 0) { - const book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); + const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true); const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", - "127", + 127, true ); myLibrary.push(book1); @@ -19,11 +24,6 @@ function populateStorage() { } } -const titleInput = document.getElementById("title"); -const authorInput = document.getElementById("author"); -const pagesInput = document.getElementById("pages"); -const readCheckbox = document.getElementById("check"); - //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function function submit() { @@ -32,8 +32,14 @@ function submit() { const trimmedPages = Number(pagesInput.value); - if (!trimmedTitle || !trimmedAuthor || !trimmedPages) { - alert("Please fill all fields!"); + if ( + !trimmedTitle || + !trimmedAuthor || + !Number.isInteger(trimmedPages) || + trimmedPages < 1 || + trimmedPages > 10000 + ) { + alert("Please enter valid book data!"); return; } const book = new Book( @@ -61,29 +67,26 @@ function Book(title, author, pages, check) { } function render() { - const table = document.getElementById("display"); - const rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n--) { - table.deleteRow(n); - } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - const row = table.insertRow(1); - const titleCell = row.insertCell(0); - const authorCell = row.insertCell(1); - const pagesCell = row.insertCell(2); - const wasReadCell = row.insertCell(3); - const deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + const tbody = document.querySelector("#display tbody"); + tbody.innerHTML = ""; + + for (let i = 0; i < myLibrary.length; i++) { + const row = document.createElement("tr"); + + const titleCell = document.createElement("td"); + const authorCell = document.createElement("td"); + const pagesCell = document.createElement("td"); + const wasReadCell = document.createElement("td"); + const deleteCell = document.createElement("td"); + + titleCell.textContent = myLibrary[i].title; + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; //add and wait for action for read/unread button const changeBut = document.createElement("button"); changeBut.className = "btn btn-success"; - changeBut.innerHTML = myLibrary[i].check ? "yes" : "No"; + changeBut.textContent = myLibrary[i].check ? "yes" : "No"; wasReadCell.appendChild(changeBut); changeBut.addEventListener("click", function () { @@ -95,12 +98,19 @@ function render() { const delButton = document.createElement("button"); deleteCell.appendChild(delButton); delButton.className = "btn btn-warning"; - delButton.innerHTML = "Delete"; + delButton.textContent = "Delete"; delButton.addEventListener("click", function () { const deletedBook = myLibrary[i]; myLibrary.splice(i, 1); render(); alert(`You've deleted title: ${deletedBook.title}`); }); + row.appendChild(titleCell); + row.appendChild(authorCell); + row.appendChild(pagesCell); + row.appendChild(wasReadCell); + row.appendChild(deleteCell); + + tbody.appendChild(row); } }