West Midlands | ITP-September-2025 | Mustaf Asani | Sprint 2 | Form-Controls #889
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
asaniDev
added
the
Needs Review
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
asaniDev
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
asaniDev
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
tenzyns
added
Review in progress
Form-Controls/index.html
Outdated
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <fieldset> | ||
| <legend><h2>Personal Information</h2></legend> |
There was a problem hiding this comment.
do you think the legend tag can just have the text string without the h2 tag or have another inline tag like strong to replace h2 to make it bold?
Form-Controls/index.html
Outdated
| </p> | ||
| </fieldset> | ||
| <fieldset> | ||
| <legend><h2>Product Information</h2></legend> |
There was a problem hiding this comment.
strong tag is useful here instead of h2 inside legend tag.
There was a problem hiding this comment.
took off the h2 tag as it turns out it was not doing anything for accessibility or semantics.
Form-Controls/index.html
Outdated
| <option value="xxlarge">XX-Large</option> | ||
| </select> | ||
| </p> | ||
| </fieldset> |
There was a problem hiding this comment.
Is the form missing a submit button? could be useful in testing field validation, even without form action?
There was a problem hiding this comment.
added a submit button to test the validation and prompts are given if the validation parameters are not met.
Form-Controls/index.html
Outdated
| <label for="firstname">Firstname:</label> | ||
| <input type="text" id="firstname" pattern=".*\S.*" title="firstname must not be only spaces" name="firstname" required minlength="2" /> | ||
| <Label for="lastname">Lastname:</Label> | ||
| <input type="text" id="lastname" pattern=".*\S.*" title="lastname must not be only spaces" name="lastname" required minlength="2" /> |
There was a problem hiding this comment.
Do you think each input element can have its own p tag or div tag, for layout flexibility and accessibility?
There was a problem hiding this comment.
used a div tag to separate the layout for the 2 input sections name and email.
Form-Controls/index.html
Outdated
| <label for="firstname">Firstname:</label> | ||
| <input type="text" id="firstname" pattern=".*\S.*" title="firstname must not be only spaces" name="firstname" required minlength="2" /> | ||
| <Label for="lastname">Lastname:</Label> | ||
| <input type="text" id="lastname" pattern=".*\S.*" title="lastname must not be only spaces" name="lastname" required minlength="2" /> |
tenzyns
added
Reviewed
asaniDev
added
the
Needs Review
tenzyns
removed
Needs Review
tenzyns
added
the
Complete
3 participants
Learners, PR Template
Self checklist
Changelist
Sprint 2 task, created a form to given specifications with only html and ran it in lighthouse then made adjustments as suggested by lighthouse to make accessibility 100%.