-
-
Notifications
You must be signed in to change notification settings - Fork 240
London | 25-ITP-Sep| Sophia Mohamed | Sprint 1 | coursework/sprint-1 #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start on this sprint's tasks, I have spotted one file where you could improve answers further
|
|
||
| // e) What do you think the variable result represents? Can you think of a better name for this variable? | ||
|
|
||
| //Duration of the movie in hours, minutes, and seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you think of how to write this? e.g. let ? = ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the code, changed the variable name and made it clearer
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think the new variable name "movieDuration" is different enough to the first "movieLength" variable? If you were looking at this code for the first time, would you know just by looking at the name what the variable "movieDuration" actually is for?
(Hint: Your original answer, identifying that it comes in hours minutes and seconds is a good observation)
|
That's true, they feel too similar. Maybe I would change it to formattedDuration, it is clear, and this is the final, formatted time string (hh:mm:ss) |
|
Great, you're finished with this sprint now |
Learners, PR Template
Self checklist
Changelist
In 1-key exercise, I completed short JavaScript programs and tasks.
2- mandatory -errors exercises are complete. I ran the code in Node.js and wrote the reason for each error
3-mandatory -interpret exercises are complete
4-Completed all stretch challenge requirements
Questions
Thank you, there is no question