Skip to content

Conversation

@saff-coder
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

In 1-key exercise, I completed short JavaScript programs and tasks.
2- mandatory -errors exercises are complete. I ran the code in Node.js and wrote the reason for each error
3-mandatory -interpret exercises are complete
4-Completed all stretch challenge requirements

Questions

Thank you, there is no question

@saff-coder saff-coder added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 10, 2025
@saff-coder saff-coder changed the title London | 25-ITP-Sept | Sophia Mohamed | Sprint 1 | coursework/sprint-1 London | 25-ITP-Sep| Sophia Mohamed | Sprint 1 | coursework/sprint-1 Oct 11, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Oct 15, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted one file where you could improve answers further


// e) What do you think the variable result represents? Can you think of a better name for this variable?

//Duration of the movie in hours, minutes, and seconds.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you think of how to write this? e.g. let ? = ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the code, changed the variable name and made it clearer

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 15, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the new variable name "movieDuration" is different enough to the first "movieLength" variable? If you were looking at this code for the first time, would you know just by looking at the name what the variable "movieDuration" actually is for?

(Hint: Your original answer, identifying that it comes in hours minutes and seconds is a good observation)

@saff-coder
Copy link
Author

saff-coder commented Oct 15, 2025

That's true, they feel too similar. Maybe I would change it to formattedDuration, it is clear, and this is the final, formatted time string (hh:mm:ss)

@LonMcGregor
Copy link

Great, you're finished with this sprint now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants