London | 25-ITP-Sept | Samuel Tarawally | Sprint 3 | Implement and rewrite tests #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarawally
added
the
Needs Review
cjyuan
reviewed
Nov 11, 2025
Comment on lines
+14
to
+15
| const numValue = parseInt(rank); | ||
| if (numValue >= 2 && numValue <= 9) return numValue; |
Contributor
There was a problem hiding this comment.
In JavaScript, strings that represent valid numeric literals in the language can be safely
converted to equivalent numbers or parsed into a valid integers.
Do you want to recognize these string values as valid ranks?
To find out what these strings are, you can ask AI
What kinds of string values would make
parseInt(rank)evaluate to2in JS?
| }); | ||
|
|
||
| test("should return 10 for face cards (J, Q, K, 10)", () => { | ||
| expect(getCardValue("10♣")).toEqual(10); |
Contributor
There was a problem hiding this comment.
I think 10 is considered a number card.
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
implementfolder.rewrite-tests-with-jest folder.