Fix: make stat cross-platform compatible (macOS/Linux) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ooh, nice. Looks good to me, thanks! |
Contributor
|
And congrats on your first contribution, as well as THE first contribution to the codebuff-community! (At least that was unsolicited.) |
Contributor
Author
|
@jahooma Thanks. I code in isolation but figured I'd branch out. No pun intended lol Been focusing on coding again for ~6 months 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using WSL2 / Ubuntu, which broke on the second run of start-codebuff.sh. The first run does the initial docker setup and doesn't touch the code that breaks.
DOCKERFILE_MTIME=$(stat -f %m "$SCRIPT_DIR/Dockerfile")The
statcommand is implemented differently for BSD vs GNU, apparently.Don't have a Mac so couldn't test it there, so this should be tested with two runs there, just to be sure.