New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail silently if they have the same name as other tests #447

Closed
lennym opened this Issue Mar 20, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@lennym
Contributor

lennym commented Mar 20, 2017

We have a suite which has a number of tests named "Happy Path".

We recently discovered that if some of them fail, then the test run still exits with a zero exit code, and our CI build passes.

This seems to be a result of this code-
https://github.com/Codeception/CodeceptJS/blob/master/lib/listener/exit.js#L19 - which removes a test from the failures list if a test with the same name later passes.

I'd recommend doing something a bit stricter than purely name matching in this case (possibly name + file, or generating a unique id for a suite/test) so that it is not possible for test failures to be ignored.

Happy to PR if you have a preferred approach.

lennym added a commit to UKHomeOffice/firearms that referenced this issue Mar 22, 2017

@APshenkin APshenkin added the bug label Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment