New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple-browser: foldername implementation issue #485

Closed
joelgrimberg opened this Issue Apr 20, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@joelgrimberg

joelgrimberg commented Apr 20, 2017

At first I want to say what a great tool Codecept.JS is for me. Thanx a lot for that!

When I test the suite via multiple-browser option, I find 2 bugs, and have 1 feature request.

  • the first browser-resolution combination I configure will be used in all folder-names for that browser.
  • screenshots in these folders are the same size
  • every device/resolution combination in my config file (for example {browser: 'chrome', windowSize: '1220x1000'},) results in my mochawesome reporter into 1 report (so 10 browser/res combinations results in 10 tabs with 10 reports). would be cool if the multiple-browser option with mochawesome results in 1 report. somehow ;)

Foldername output when testing via multiplebrowser option:

drwxr-xr-x 7 joel staff 238B Apr 20 19:25 basic_browser_chrome_windowSize_1220x1000_1
drwxr-xr-x 7 joel staff 238B Apr 20 19:25 basic_browser_chrome_windowSize_1220x1000_2
drwxr-xr-x 7 joel staff 238B Apr 20 19:25 basic_browser_chrome_windowSize_1220x1000_3
drwxr-xr-x 7 joel staff 238B Apr 20 19:25 basic_browser_chrome_windowSize_1220x1000_4
drwxr-xr-x 7 joel staff 238B Apr 20 19:25 basic_browser_firefox_windowSize_maximize_5
drwxr-xr-x 7 joel staff 238B Apr 20 19:24 basic_browser_firefox_windowSize_maximize_6
drwxr-xr-x 7 joel staff 238B Apr 20 19:24 basic_browser_firefox_windowSize_maximize_7
drwxr-xr-x 7 joel staff 238B Apr 20 19:24 basic_browser_firefox_windowSize_maximize_8
drwxr-xr-x 7 joel staff 238B Apr 20 19:25 basic_browser_firefox_windowSize_maximize_9
drwxr-xr-x 3 joel staff 102B Apr 20 19:24 basic_browser_safari_windowSize_maximize_10
drwxr-xr-x 3 joel staff 102B Apr 20 19:24 basic_browser_safari_windowSize_maximize_11
drwxr-xr-x 2 joel staff 68B Apr 20 19:24 basic_browser_safari_windowSize_maximize_12
drwxr-xr-x 2 joel staff 68B Apr 20 19:24 basic_browser_safari_windowSize_maximize_13
drwxr-xr-x 3 joel staff 102B Apr 20 19:24 basic_browser_safari_windowSize_maximize_14

multi-browser configuration:

      "browsers" :
      [
        {browser: 'chrome', windowSize: '1220x1000'},
        {browser: 'chrome', windowSize: '1024x1000'},
        {browser: 'chrome', windowSize: '768x1000'},
        {browser: 'chrome', windowSize: '320x1000'},

        {browser: 'firefox', windowSize: 'maximize'},
        {browser: 'firefox', windowSize: '1220x1000'},
        {browser: 'firefox', windowSize: '1024x1000'},
        {browser: 'firefox', windowSize: '768x1000'},
        {browser: 'firefox', windowSize: '320x1000'},

        {browser: 'safari', windowSize: 'maximize'},
        {browser: 'safari', windowSize: '1220x1000'},
        {browser: 'safari', windowSize: '1024x1000'},
        {browser: 'safari', windowSize: '768x1000'},
        {browser: 'safari', windowSize: '320x1000'}
    ]
@shrikanthkm07

This comment has been minimized.

Show comment
Hide comment
@shrikanthkm07

shrikanthkm07 Apr 21, 2017

Can someone please provide a working example for this multiple browser implementation? I tried but its not working properly. Some simple example with config pls.

shrikanthkm07 commented Apr 21, 2017

Can someone please provide a working example for this multiple browser implementation? I tried but its not working properly. Some simple example with config pls.

@joelgrimberg

This comment has been minimized.

Show comment
Hide comment
@shrikanthkm07

This comment has been minimized.

Show comment
Hide comment
@shrikanthkm07

shrikanthkm07 commented Apr 24, 2017

Thanks @joelgrimberg !!!

@joelgrimberg

This comment has been minimized.

Show comment
Hide comment
@joelgrimberg

joelgrimberg Apr 24, 2017

@shrikanthkm07 you're welcome. Just let me know if you have questions.

joelgrimberg commented Apr 24, 2017

@shrikanthkm07 you're welcome. Just let me know if you have questions.

@APshenkin

This comment has been minimized.

Show comment
Hide comment
@APshenkin

APshenkin Jun 1, 2017

Collaborator

@joelgrimberg Looks like first two issues is the same (multiple option just starts 5 instances with the same resolution). I'll check it.

About aggregation report feature - Every suite is running in separate child process and it would be hard to mix all reports in one. I think that we can do some aggregator for reports that will generate one more page, that will contains list of links to reports. Will investigate this

Collaborator

APshenkin commented Jun 1, 2017

@joelgrimberg Looks like first two issues is the same (multiple option just starts 5 instances with the same resolution). I'll check it.

About aggregation report feature - Every suite is running in separate child process and it would be hard to mix all reports in one. I think that we can do some aggregator for reports that will generate one more page, that will contains list of links to reports. Will investigate this

@APshenkin APshenkin self-assigned this Jun 1, 2017

@APshenkin APshenkin referenced this issue Aug 24, 2017

Merged

Multiple fix #679

@APshenkin

This comment has been minimized.

Show comment
Hide comment
@APshenkin

APshenkin Aug 24, 2017

Collaborator

Fix is ready to merge to master.

About reports dashboard: will monitor this issue in mochawesome adamgruber/mochawesome#90. When it will be ready we will use it to automatically generate dashboard

Collaborator

APshenkin commented Aug 24, 2017

Fix is ready to merge to master.

About reports dashboard: will monitor this issue in mochawesome adamgruber/mochawesome#90. When it will be ready we will use it to automatically generate dashboard

@DavertMik DavertMik closed this in #679 Aug 24, 2017

@lsq4590578

This comment has been minimized.

Show comment
Hide comment
@lsq4590578

lsq4590578 Nov 30, 2017

@joelgrimberg
How do I configure multiple suites to run on different Chrome browsers?I don't know how to config it.Please help to me,thanks
"multiple": {
"suiteName": "",
"suiteConf": "",
"browser": [
"chrome"
]
},

lsq4590578 commented Nov 30, 2017

@joelgrimberg
How do I configure multiple suites to run on different Chrome browsers?I don't know how to config it.Please help to me,thanks
"multiple": {
"suiteName": "",
"suiteConf": "",
"browser": [
"chrome"
]
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment