New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple.parallel.chunks #1238

Merged
merged 2 commits into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@ngadiyak
Contributor

ngadiyak commented Oct 2, 2018

if multiple.parallel.chunks param in codecept.conf.js set as environment variable, codeceptjs throw "chunks is neither a finite number or a valid function".

example:

    multiple: {
        parallel: {
            chunks: process.env.CHUNKS || 20,
            ...
        }
fix multiple.parallel.chunks
if multiple.parallel.chunks param in config set as environment variable, than codeceptjs throw "chunks is neither a finite number or a valid function".
@@ -62,7 +62,7 @@ const createChunks = (config, pattern) => {
let chunks = [];
if (typeof config.chunks === 'function') {
chunks = config.chunks.call(this, files);
} else if (typeof config.chunks === 'number') {
} else if (typeof config.chunks === 'number' || typeof config.chunks === 'string' ) {

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2018

There should be no spaces inside this paren space-in-parens

@DavertMik

This comment has been minimized.

Member

DavertMik commented Oct 4, 2018

Thanks!

@DavertMik DavertMik merged commit fc36a8d into Codeception:master Oct 4, 2018

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@ngadiyak ngadiyak deleted the ngadiyak:patch-1 branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment