New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use WSEndpoint on Puppeteer #1350

merged 1 commit into from Dec 19, 2018


None yet
2 participants
Copy link

gabrielcaires commented Nov 22, 2018

With this PR will be possible to use remote chrome instances like or docker containers like

I saw that currently the project is not mocking Puppeteer and we don't have tests to _startBrowser, so I don't know how test it. Should I mock Puppeteer?

@@ -59,7 +59,8 @@ const consoleLogStore = new Console();
* ```js
* "chrome": {
* "executablePath" : "/path/to/Chrome"
* "executablePath" : "/path/to/Chrome",
* "browserWSEndpoint": "ws://localhost:3000"

This comment has been minimized.


DavertMik Nov 23, 2018


thanks. Can you add here an example here for using CodeceptJS with


This comment has been minimized.

Copy link

DavertMik commented Nov 23, 2018

I think for such case we are fine without a test
Just update the docs and we are fine!

@DavertMik DavertMik merged commit 15c7595 into Codeception:master Dec 19, 2018

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
semaphoreci The build passed on Semaphore.

This comment has been minimized.

Copy link

DavertMik commented Dec 19, 2018

Ok, I will update docs on my own

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment