New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Uploading To Hidden Input Element #1460

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@tsuemura
Copy link
Contributor

tsuemura commented Jan 22, 2019

Original WebDriver helper's attachFile() method could'nt attach file to hidden input element, such as:

<input type="file" id="upload" style="display: none;">

Given error was:

     Error: element not interactable
  (Session info: headless chrome=70.0.3538.77)
  (Driver info: chromedriver=2.43.600233 (523efee95e3d68b8719b3a1c83051aa63aa6b10d),platform=Linux 4.17.9-041709-generic x86_64)

This patch will fixed that problem.

@DavertMik

This comment has been minimized.

Copy link
Member

DavertMik commented Jan 22, 2019

Thanks!

@DavertMik DavertMik merged commit 473f351 into Codeception:master Jan 22, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

DavertMik added a commit that referenced this pull request Jan 31, 2019

Fix/1422 save screenshot on windows (#1470)
* synced with master (#1)

* Added WebDriver to autoDelay supported helpers (#1455)

WebDriverIO is deprecated and should be removed from the list when the deprecation notices are removed.

* Fix multiple-execution link (#1456)

* add label to allure report + fix collect tag (#1449)

* Skip test in allure-report (#1448)

* Fix issue 1445 and 1443 (#1446)

* Fix running tests with different data and with only

* fix

* remove only

* fix comment

* fix comments

* fix issue 1443

* use JSON.stringify for all obj

* Change setValue() to addValue() (and add some tests) (#1460)

* improved TS definitions

* fixed the case when there are more than one matched element (#1453)

* fixed the case when there are more than one matched element

* fixed the same thing for nightmare and protractor

* prepare release and website update

* fixed the case the folder to save screenshot is duplicated on windows

* fixed the case the folder to save screenshot is duplicated on windows

* lint fixed

* removed the lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment