Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Puppeteer): checkRequirements failed when use only puppeteer-firefox #1773

Closed
wants to merge 2 commits into from

Conversation

Vorobeyko
Copy link
Collaborator

When require Puppeteer with puppeteer-firefox and not install puppeteer - I obtains exception:

Could not load helper Puppeteer from module '...':
Cannot read property 'browser' of undefined

@DavertMik
Copy link
Contributor

I think checkRequirements won't work for both packages puppeteer and puppeteer-firefox.
A proper solution would be to create PuppeteerFirefox helper which extends from Puppeteer.
Then we can easily override _checkRequirements.

@DavertMik DavertMik closed this Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants