Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated webdriver.js #1777

Merged

Conversation

@gagandeepsingh26
Copy link
Contributor

commented Jul 16, 2019

Made changes for the fillField helper. Added a line to speed up adding of text for an element having accessibility ID. Efficiency improved for fill field for iOS guys

Updated webdriver.js
Made changes for the fillField helper. Added a line to speed up adding of text for an element having accessibility ID. Efficiency improved for fill field for iOS guys
@@ -2161,6 +2161,8 @@ async function findClickable(locator, locateFn) {

async function findFields(locator) {
locator = new Locator(locator);
if (locator.isAccessibilityId()) return this._locate(locator, true);

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jul 16, 2019

Trailing spaces not allowed no-trailing-spaces

@codacy-bot

This comment has been minimized.

Copy link

commented Jul 16, 2019

Codacy Here is an overview of what got changed by this pull request:

Clones removed
==============
+ lib/helper/WebDriver.js  -1
         

See the complete overview on Codacy

@Codeception Codeception deleted a comment from codacy-bot Jul 16, 2019

@Codeception Codeception deleted a comment from codacy-bot Jul 16, 2019

@gagandeepsingh26

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

@DavertMik
Hi,
Above failure are not due to my changes. Please review once and can you please trigger the builds again.

Thanks

@DavertMik

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

@gagandeepsingh26 I was wondering, maybe this should be included into findClickable as well?

@DavertMik

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

Thanks

@DavertMik DavertMik merged commit d026ff1 into Codeception:master Aug 15, 2019

3 of 5 checks passed

ci/circleci: docker Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Hound No violations found. Woof!
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.