Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mocha to 6 #1802

Merged
merged 11 commits into from Aug 12, 2019

Conversation

@elukoyanov
Copy link
Contributor

commented Jul 25, 2019

  • update mocha package version
  • remove co-mocha (does not support mocha 6) and generators in tests
package.json Outdated Show resolved Hide resolved
elukoyanov and others added 5 commits Jul 26, 2019
Update package.json
Change mocha version to 6.2.0+

Co-Authored-By: Vikalp <vikalppanseriya@gmail.com>

@Codeception Codeception deleted a comment from codacy-bot Jul 26, 2019

@Codeception Codeception deleted a comment from codacy-bot Jul 26, 2019

@Codeception Codeception deleted a comment from codacy-bot Jul 31, 2019

@Codeception Codeception deleted a comment from codacy-bot Jul 31, 2019

@Codeception Codeception deleted a comment from codacy-bot Jul 31, 2019

@elukoyanov

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

@DavertMik , I look into mochaFactory.
There are using of mocha with loadFiles and Runner.uncaught overriding.

In the ui.js file tags, inject, and others are added to Mocha.Test, Mocha.Suite and others.

Maybe, analogues CodeceptMocha/CodeceptTest/CodeceptSuite should be created as class extension instead of monkey patching Mocha classes themself?

Can do in this or other PR.

@DavertMik

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Maybe, analogues CodeceptMocha/CodeceptTest/CodeceptSuite should be created as class extension instead of monkey patching Mocha classes themself?

A good idea. That would be really nice!

Filenames can be like:
lib/mocha/test.js
lib/mocha/suite.js

@DavertMik

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

I tried your branch locally. Works really great. Waiting to see this merged!

@DavertMik

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

@elukoyanov is this PR ready?

@elukoyanov

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

It can be merged.
I'll make mocha class variation in other PR

@elukoyanov elukoyanov marked this pull request as ready for review Aug 10, 2019

@elukoyanov elukoyanov changed the title WIP: update mocha to 6 update mocha to 6 Aug 10, 2019

@codacy-bot

This comment has been minimized.

Copy link

commented Aug 12, 2019

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/plugin/screenshotOnFail.js  1
         

Complexity decreasing per file
==============================
+ test/helper/webapi.js  -1
         

Clones added
============
- test/helper/WebDriverIO_test.js  1
- test/helper/ProtractorWeb_test.js  1
- test/helper/webapi.js  4
- test/helper/Appium_test.js  10
         

Clones removed
==============
+ test/helper/AppiumWeb_test.js  -3
+ test/helper/WebDriver_test.js  -4
+ test/helper/Nightmare_test.js  -1
+ test/helper/Protractor_test.js  -1
         

See the complete overview on Codacy

@Codeception Codeception deleted a comment from codacy-bot Aug 12, 2019

@DavertMik DavertMik merged commit 98fe661 into Codeception:master Aug 12, 2019

3 of 5 checks passed

ci/circleci: docker Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Hound No violations found. Woof!
semaphoreci The build passed on Semaphore.
Details
@DavertMik

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.