Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure configured user agent and/or window size is applied to all pages. #1862

Conversation

@martomo
Copy link
Contributor

commented Aug 27, 2019

Prior only initial page would have configuration applied, new pages/tabs or (incognito) sessions would have default values.

Ensure configured user agent and/or window size is applied to all pages.
Prior only initial page would have configuration applied, new pages/tabs or (incognito) sessions would have default values.
@codacy-bot

This comment has been minimized.

Copy link

commented Aug 27, 2019

Codacy Here is an overview of what got changed by this pull request:

Clones removed
==============
+ lib/helper/Puppeteer.js  -1
         

See the complete overview on Codacy

@DavertMik

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Thanks, this really was an issue, even to me, but I didn't have a chance to fix that!

@DavertMik DavertMik merged commit 4729d48 into Codeception:master Sep 6, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Hound No violations found. Woof!
ci/circleci: docker Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@martomo martomo deleted the martomo:fix-puppeteer-configure-page-on-creation branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.