Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mismatch tags from title will cause null tag #2038

Merged
merged 2 commits into from Nov 22, 2019

Conversation

@javcof
Copy link
Contributor

javcof commented Nov 20, 2019

Motivation/Description of the PR

Applicable helpers:

  • Webdriver

  • Puppeteer

  • Nightmare

  • REST

  • Appium

  • Protractor

  • TestCafe

  • Codecept will always match test case title prefix ‘@’ string and push to test tags array,
    If match failed will cause the null tag issue.

Type of change

  • Breaking changes
  • New functionality
  • Bug fix
  • Documentation changes/updates
  • Hot fix
  • Markdown files fix - not related to source code

Checklist:

  • Tests have been added
  • Documentation has been added (Run robo docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)
@PeterNgTr PeterNgTr added the WIP label Nov 20, 2019
@PeterNgTr

This comment has been minimized.

Copy link
Collaborator

PeterNgTr commented Nov 20, 2019

Jerry Zhang
@DavertMik

This comment has been minimized.

Copy link
Member

DavertMik commented Nov 21, 2019

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/ui.js  1
         

See the complete overview on Codacy

@javcof

This comment has been minimized.

Copy link
Contributor Author

javcof commented Nov 22, 2019

@PeterNgTr @PeterNgTr CircleCI build failed, what should I do?

@javcof javcof marked this pull request as ready for review Nov 22, 2019
@PeterNgTr

This comment has been minimized.

Copy link
Collaborator

PeterNgTr commented Nov 22, 2019

Let me rerun the CI.

@Vorobeyko Vorobeyko self-requested a review Nov 22, 2019
@Vorobeyko Vorobeyko merged commit 954fc17 into Codeception:master Nov 22, 2019
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Hound No violations found. Woof!
ci/circleci: docker Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@Vorobeyko Vorobeyko added ready for merging and removed WIP labels Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.