New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to manually start the browser. #255

Merged
merged 4 commits into from Oct 18, 2016

Conversation

Projects
None yet
2 participants
@cnworks
Contributor

cnworks commented Oct 14, 2016

To work with cloud services like browserstack it can be beneficial to control when the session is started and therefore start the session manually.

One case in which this is useful is issue #190. You can set the desiredCapability.name and then start the session by executing this.helpers['WebDriverIO']._startBrowser()

As the manual option is set to false by default the behavior doesn't change.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 18, 2016

Member

Thanks for the PR. I like the implementation but I don't like naming, probably they should be more explicit about the problem it solves. manualStart looks like it expects you to launch a browser locally and wait the Selenium to handle its session (somehow).

Maybe it should be named like reuseSession or smth else... With documentation for potential use case at cloud service providers

Member

DavertMik commented Oct 18, 2016

Thanks for the PR. I like the implementation but I don't like naming, probably they should be more explicit about the problem it solves. manualStart looks like it expects you to launch a browser locally and wait the Selenium to handle its session (somehow).

Maybe it should be named like reuseSession or smth else... With documentation for potential use case at cloud service providers

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Oct 18, 2016

Member

@cnworks when I merge your PR could you help the project a bit more. I was thinking it would be useful to have dedicated "Cloud Testing" guide in documentation. Could you write some paragraphs on it, to share your experience?

Member

DavertMik commented Oct 18, 2016

@cnworks when I merge your PR could you help the project a bit more. I was thinking it would be useful to have dedicated "Cloud Testing" guide in documentation. Could you write some paragraphs on it, to share your experience?

@DavertMik DavertMik merged commit 94e38eb into Codeception:master Oct 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Nighthawk14 added a commit to Nighthawk14/CodeceptJS that referenced this pull request Nov 7, 2016

Update upstream (#2)
* fixed definition generation

* Fix def command (#223)

* Fix def command

Container does not have getTranslations() method, just translation().

* Fix def command

Fix typo in previous commit.

* updated version and changelog

* BeforeSuite and AfterSuite implement (#231)

* close tabs after test, close browser after all tests

* revert changes, fix afterAll

* experemental

* Implement BeforeSuite AfterSuite

* Remove temp changes

* remove formatting

* remove formatting

* remove Formatting

* Fix AfterSuite Hook

* Fix formatting

* updated docs for beforesuite

* version bump

* small fixes

* Update docs for beforeSuite/afterSuite and fix restart false (#240)

* close tabs after test, close browser after all tests

* revert changes, fix afterAll

* experemental

* Implement BeforeSuite AfterSuite

* Remove temp changes

* remove formatting

* remove formatting

* remove Formatting

* Fix AfterSuite Hook

* Fix formatting

* Update docs

* Update docs 2

* Update docs 3

* Fix "restart: false"

* version bump

* updated version, changelog

* updated docs

* Update attachFile.mustache

* Update SeleniumWebdriver.js

* Use global actor function in Page Objects docs (#251)

* Use global actor function in Page Objects docs

As suggested in https://github.com/Codeception/CodeceptJS/blob/master/CHANGELOG.md#022 , otherwise the example code might not work as expected.

* Update remaining usages of 'codeceptjs/actor'

* Fix attachFile on WebDriverIO helper (#254)

* Fix attachFile on WebDriverIO helper

* Improve check on returned element

* Update to helpers docs (#264)

* update to helpers docs

* updated docs

* fixed file uploads fro WebDriverIO (#265)

* Update helpers.md

* Update helpers.md

* Add support for webdriver.io timeouts (#258)

This adds support for each possible timeouts option in webdriver.io

In your codecept.conf.js you can express it something like:

```
{
  ...
  WebDriverIO: {
    url: 'http://localhost:8080',
    browser: 'phantomjs',
    timeouts: {
      implicit: 10000,
      page_load: 20000
      script: 5000
    }
  }
}
```

* do not throw error in dispatcher (#263)

* do not throw error, emit it!

fix issue Codeception#262

* remove emit error

* catch mocha fail

* Improved timeouts for WebdriverIO (#267)

* added timeouts to config section and defineTimeout method

* tiny typo

* fixed Nightmare bug: unable to locate and click element; async improv… (#268)

* fixed Nightmare bug: unable to locate and click element; async improvements

* added fix and test for Nightmare not located clicable element

* fix test generation (#260)

* using unlinkSync to prepare tests

* Added option to manually start the browser. (#255)

* Added manual option to WebDriverIO helper, to start client manualy.

* Added option to manualy start the browser.

* added config param in docs

* Generators fix (#270)

* added mkdirp for recursive directory creation

* init creates all required dirs

* Added config option descriptions for manualStart option (#271)

* added config option descriptions for manualStart option

* manual start renamed back

* Added moveCursorTo to Protractor, Nightmare, SeleniumWebdriver (#269)

* [SeleniumWebdriver][Protrctor][Nightmare] Added moveCursorTo and basic test

* added wait for hover test

* fixed moveCursorTo test

* another try to fix hover test

* fixed test

* another try for the test fix

* disabling hover test

* updated changelog

* updated docs

* fixed gt example

* updated mocha to fix security issue (#273)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment