New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saveScreenshot() for PhantomJS #549

Merged
merged 7 commits into from Jun 20, 2017

Conversation

Projects
None yet
2 participants
@HughZurname
Contributor

HughZurname commented Jun 7, 2017

Changes:

  • Updated other helpers to use options for configuring fullPageScreenshots.

Fixes:

  • Resolves #540 based on suggestion.

This was referenced Jun 12, 2017

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Jun 20, 2017

Member

Looks good. Thank you!

Member

DavertMik commented Jun 20, 2017

Looks good. Thank you!

@DavertMik DavertMik merged commit c4ca3d1 into Codeception:master Jun 20, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment