Navigation Menu

Skip to content

Commit

Permalink
Don't skip last test if some test has missing dependency
Browse files Browse the repository at this point in the history
Fixes #4598
  • Loading branch information
Naktibalda committed Nov 2, 2017
1 parent d64f8dd commit 26d0b62
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/Codeception/Suite.php
Expand Up @@ -27,6 +27,7 @@ public function reorderDependencies()
}
$this->tests = $queue;
}

protected function getDependencies($test)
{
if (!$test instanceof Dependent) {
Expand All @@ -43,6 +44,7 @@ protected function getDependencies($test)
$tests[] = $test;
return $tests;
}

protected function findMatchedTest($testSignature)
{
foreach ($this->tests as $test) {
Expand All @@ -51,9 +53,6 @@ protected function findMatchedTest($testSignature)
return $test;
}
}
if ($test instanceof TestInterface) {
$test->getMetadata()->setSkip("Dependent test for $testSignature not found");
}
}

/**
Expand Down

0 comments on commit 26d0b62

Please sign in to comment.