Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitForText is marked as internal #1741

Closed
javigomez opened this issue Feb 24, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@javigomez
Copy link
Contributor

commented Feb 24, 2015

Not sure, but I think this docblock here is not needed:

screen shot 2015-02-24 at 14 31 02

Is causing this:

screen shot 2015-02-24 at 14 31 24

Witch I think is not the purpose, isn't it?

@DavertMik

This comment has been minimized.

Copy link
Member

commented Feb 24, 2015

Yeah, really strange why so. Could you send a PR to fix it?
24 лют. 2015 15:28, користувач "javier gomez" notifications@github.com
написав:

Not sure, but I think this docblock here is not needed:

[image: screen shot 2015-02-24 at 14 31 02]
https://cloud.githubusercontent.com/assets/1375475/6350122/5516553e-bc31-11e4-83c6-0e2cb251ce0b.png

Is causing this:

[image: screen shot 2015-02-24 at 14 31 24]
https://cloud.githubusercontent.com/assets/1375475/6350129/60adb8c4-bc31-11e4-9395-80a8ed51fe68.png

Witch I think is not the purpose, isn't it?


Reply to this email directly or view it on GitHub
#1741.

@DavertMik DavertMik closed this Apr 9, 2015

@javigomez

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2015

Oops just got the update of that issue. Sorry. Do you still need the PR or is already fixed?

@javigomez

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2015

I found my issue, my configuration needs to be like this:

config:
        Codeception\Extension\Recorder:
            delete_successful: false
            module: JoomlaBrowser

Because I'm using the JoomlaBrowser Extension http://codeception.com/addons#Extensions

Thanks

@DavertMik

This comment has been minimized.

Copy link
Member

commented Aug 6, 2015

@javigomez looks like you accidentally wrote to this issue )

@javigomez

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2015

agg! that comment was for a different issue 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.