Update Facebook Driver for Facebook SDK v5 #2415

Closed
JarJak opened this Issue Sep 29, 2015 · 6 comments

Comments

Projects
None yet
5 participants
@JarJak
Contributor

JarJak commented Sep 29, 2015

Facebook Driver needs to be updated because its not working anymore...
For now it's compatible only with SDK v4:
8993ccb
which is not working anymore and new version of SDK is incompatible with what we have there, for example there is no FacebookSession class anymore.

@JarJak

This comment has been minimized.

Show comment
Hide comment
@JarJak

JarJak Dec 16, 2015

Contributor

any news about this issue?

Contributor

JarJak commented Dec 16, 2015

any news about this issue?

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Dec 16, 2015

Member

No, would you like to do it?

Member

Naktibalda commented Dec 16, 2015

No, would you like to do it?

@JarJak

This comment has been minimized.

Show comment
Hide comment
@JarJak

JarJak Dec 21, 2015

Contributor

i'm not sure how

Contributor

JarJak commented Dec 21, 2015

i'm not sure how

@orhan-swe

This comment has been minimized.

Show comment
Hide comment
@orhan-swe

orhan-swe Jan 14, 2016

Contributor

I have created a pull request for this: #2722 but my changes will break support for version 4 of sdk

Contributor

orhan-swe commented Jan 14, 2016

I have created a pull request for this: #2722 but my changes will break support for version 4 of sdk

@Naktibalda Naktibalda added this to the 2.2 milestone Feb 21, 2016

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Feb 21, 2016

Member

Hi @tiger-seo,

When you wrote
@orhan-swe please, resend your PR to branch Codeception:feature/facebook-upgrade, so that we can finish it and merge to the 2.1. thanks, did you mean that you are going to finish it yourself?

I think that it would be better to merge this change to master branch.

Member

Naktibalda commented Feb 21, 2016

Hi @tiger-seo,

When you wrote
@orhan-swe please, resend your PR to branch Codeception:feature/facebook-upgrade, so that we can finish it and merge to the 2.1. thanks, did you mean that you are going to finish it yourself?

I think that it would be better to merge this change to master branch.

@tiger-seo

This comment has been minimized.

Show comment
Hide comment
@tiger-seo

tiger-seo Feb 22, 2016

Member

yea, let's merge it #2828

Member

tiger-seo commented Feb 22, 2016

yea, let's merge it #2828

@DavertMik DavertMik closed this Mar 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment