Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Facebook Driver for Facebook SDK v5 #2415

Closed
JarJak opened this issue Sep 29, 2015 · 6 comments
Closed

Update Facebook Driver for Facebook SDK v5 #2415

JarJak opened this issue Sep 29, 2015 · 6 comments
Assignees
Milestone

Comments

@JarJak
Copy link
Contributor

@JarJak JarJak commented Sep 29, 2015

Facebook Driver needs to be updated because its not working anymore...
For now it's compatible only with SDK v4:
8993ccb
which is not working anymore and new version of SDK is incompatible with what we have there, for example there is no FacebookSession class anymore.

@JarJak
Copy link
Contributor Author

@JarJak JarJak commented Dec 16, 2015

any news about this issue?

@Naktibalda
Copy link
Member

@Naktibalda Naktibalda commented Dec 16, 2015

No, would you like to do it?

@JarJak
Copy link
Contributor Author

@JarJak JarJak commented Dec 21, 2015

i'm not sure how

@orhan-swe
Copy link
Contributor

@orhan-swe orhan-swe commented Jan 14, 2016

I have created a pull request for this: #2722 but my changes will break support for version 4 of sdk

@Naktibalda Naktibalda added this to the 2.2 milestone Feb 21, 2016
@Naktibalda
Copy link
Member

@Naktibalda Naktibalda commented Feb 21, 2016

Hi @tiger-seo,

When you wrote
@orhan-swe please, resend your PR to branch Codeception:feature/facebook-upgrade, so that we can finish it and merge to the 2.1. thanks, did you mean that you are going to finish it yourself?

I think that it would be better to merge this change to master branch.

@tiger-seo
Copy link
Member

@tiger-seo tiger-seo commented Feb 22, 2016

yea, let's merge it #2828

@DavertMik DavertMik closed this Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.