Wrong default parameter value for Actor methods' #2453

Closed
codemedic opened this Issue Oct 16, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@codemedic
Contributor

codemedic commented Oct 16, 2015

Irrespective of what is defined in the module from which these methods are derived, the value assumed in the parameter lost of those grafted methods always assume null.
Going a little further with the reflection based grafting that occurs during the build step, it is possible to make it better. ( I have a working proof of concept ).

@codemedic codemedic changed the title from build command assumes wrong default for Actor methods' default parameter value to Wrong default parameter value for Actor methods' Oct 16, 2015

codemedic added a commit to redmatter/Codeception that referenced this issue Oct 16, 2015

Fixing issue #2453
Added reflection based parameter inspection to derive default values

codemedic added a commit to redmatter/Codeception that referenced this issue Oct 19, 2015

Fixing issue #2453
Added reflection based parameter inspection to derive default values

codemedic added a commit to redmatter/Codeception that referenced this issue Oct 19, 2015

codemedic added a commit to redmatter/Codeception that referenced this issue Oct 21, 2015

Based on comments from PR, making more use of what PHP's native funct…
…ions can provide #2453 (v2.1)

Also fixes a bug in the way arrays were exported; string keys and values were not properly encoded.

DavertMik added a commit that referenced this issue Oct 24, 2015

Merge pull request #2458 from natterbox/fix-2453-default-parameter-va…
…lue-v2.1

Fixing issue #2453 - Default param is always null

@Naktibalda Naktibalda closed this Oct 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment