setCookie "expire" param documentation wrong; implementations differ #2582

Closed
oehlschl opened this Issue Nov 25, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@oehlschl
Contributor

oehlschl commented Nov 25, 2015

Both the WebDriver and PhpBrowser readme files list "expire" as the parameter for setting cookie expirations, though it looks like that's incorrect in both cases; Facebook's WebDriver expects "expiry", and PhpBrowser expects "expires". I noticed the WebDriver issue when all of our cookies appeared as session cookies and then looked into the source. You could just update the documentation, but you may want to also/instead add a shim to maintain the interface across both clients.

@DavertMik DavertMik closed this in eff1efc Nov 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment