Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
setCookie "expire" param documentation wrong; implementations differ #2582
Both the WebDriver and PhpBrowser readme files list "expire" as the parameter for setting cookie expirations, though it looks like that's incorrect in both cases; Facebook's WebDriver expects "expiry", and PhpBrowser expects "expires". I noticed the WebDriver issue when all of our cookies appeared as session cookies and then looked into the source. You could just update the documentation, but you may want to also/instead add a shim to maintain the interface across both clients.