Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCookie "expire" param documentation wrong; implementations differ #2582

Closed
oehlschl opened this issue Nov 25, 2015 · 0 comments
Closed

setCookie "expire" param documentation wrong; implementations differ #2582

oehlschl opened this issue Nov 25, 2015 · 0 comments

Comments

@oehlschl
Copy link
Contributor

@oehlschl oehlschl commented Nov 25, 2015

Both the WebDriver and PhpBrowser readme files list "expire" as the parameter for setting cookie expirations, though it looks like that's incorrect in both cases; Facebook's WebDriver expects "expiry", and PhpBrowser expects "expires". I noticed the WebDriver issue when all of our cookies appeared as session cookies and then looked into the source. You could just update the documentation, but you may want to also/instead add a shim to maintain the interface across both clients.

@DavertMik DavertMik closed this in eff1efc Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.