Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted commit for Cest classes #299

Closed
Ragazzo opened this issue May 8, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@Ragazzo
Copy link
Contributor

commented May 8, 2013

I think this commit is wrong, see this
6923cfd
and base CestCase for all cest-classes
https://github.com/Codeception/Codeception/blob/master/src/Codeception/CestCase.php

I think it is better to pass event object and not scenario, because scenario is always the same for public test, does not matter if it failed or not, and events make more sense.

@DavertMik

This comment has been minimized.

Copy link
Member

commented May 8, 2013

👍 You are right.

@DavertMik DavertMik closed this May 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.