New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unencoded html breaks report #3819

Closed
mpgo13 opened this Issue Dec 6, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@mpgo13
Contributor

mpgo13 commented Dec 6, 2016

What are you trying to achieve?

One of my test contains a step like:

$I->fillField($textArea, "... <script> ...");

Running codecept with --html option should generate a well encoded report.

What do you get instead?

Actual result is a broken HTML report, containing the step as HTML code instead of encoded text (script tag breaks html)

Details

Unrelated to the issue

@DavertMik DavertMik added the Reports label Dec 6, 2016

@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda May 14, 2017

Member

Fixed by #4175

Member

Naktibalda commented May 14, 2017

Fixed by #4175

@Naktibalda Naktibalda closed this May 14, 2017

@mpgo13

This comment has been minimized.

Show comment
Hide comment
@mpgo13

mpgo13 Jul 12, 2017

Contributor

Still a problem when passing html to functions (in particular :


class HtmlCest
{
    private function login($username) { }
   
    public function testXSS()
    {
        $this->login("a<script>");
    }
}

Produces unencoded html report:
image

Contributor

mpgo13 commented Jul 12, 2017

Still a problem when passing html to functions (in particular :


class HtmlCest
{
    private function login($username) { }
   
    public function testXSS()
    {
        $this->login("a<script>");
    }
}

Produces unencoded html report:
image

mpgo13 added a commit to mpgo13/Codeception that referenced this issue Jul 13, 2017

Naktibalda added a commit that referenced this issue Jul 14, 2017

mpgo13 added a commit to mpgo13/Codeception that referenced this issue Jul 26, 2017

DavertMik added a commit that referenced this issue Jul 31, 2017

Fix another HTML report encoding issue #4423 (#4422)
* Fix another HTML report encoding issue #3819

* Use fixed variable #4423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment