New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REST] seeResponseJsonMatchesXpath unexpectedly fails when response contains a single element #3827

Closed
Naktibalda opened this Issue Dec 9, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@Naktibalda
Member

Naktibalda commented Dec 9, 2016

Test code:

$I->sendPOST('/api', []);
$I->seeResponseJsonMatchesXpath('//success');

Response:

 {"success":0}

Expected Result:
PASSED

Actual Result:

  [PHPUnit_Framework_Exception] Invalid argument supplied for foreach()

/.../vendor/codeception/codeception/src/Codeception/Util/JsonArray.php:96
/.../vendor/codeception/codeception/src/Codeception/Util/JsonArray.php:57
/.../vendor/codeception/codeception/src/Codeception/Util/JsonArray.php:72
/.../vendor/codeception/codeception/src/Codeception/Module/REST.php:773

Lines 94-96:

private function arrayToXml(\DOMDocument $doc, \DOMNode $node, $array)
{
    foreach ($array as $key => $value) {

The culprit is this code:

if (count($jsonArray) == 1) {
    $root = key($jsonArray);
    $jsonArray = reset($jsonArray);
}

Naktibalda added a commit to Naktibalda/Codeception that referenced this issue Dec 10, 2016

@DavertMik DavertMik closed this in #3828 Dec 12, 2016

DavertMik added a commit that referenced this issue Dec 12, 2016

chris1312 added a commit to chris1312/Codeception that referenced this issue Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment