New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should generate:suite also create the appropriate test folder? #4251

Closed
krukru opened this Issue May 24, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@krukru

krukru commented May 24, 2017

What are you trying to achieve?

When adding a new suite I would expect that the test folder for the new suite (tests/some-new-suite) would also be created, but it does not get created until you generate your first test in that suite.

How to reproduce?

  1. In a clean folder, run codecept bootstrap. Note that the tests/unit, tests/functional, tests/acceptance folders are created, but empty
  2. Create a new suite codecept generate:suite integration

Expected: The folder tests/integration has been created, just like unit/functional/acceptance have empty folders
Actual: The folder is missing until you create your first test in that suite.

Maybe I am wrong, but it would be consistent with codecept bootstrap to also create the tests folder at suite-creation time.

I can put together a PR if needed

Details

  • Codeception version: 2.3.1
  • PHP Version: PHP 7.0.17 (cli) (built: Apr 3 2017 13:42:03) ( NTS )
  • Operating System: macOS Sierrs 10.12.4
  • Installation type: Composer
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik May 25, 2017

Member

Looks like a regression of 2.3
Before 2.3 we had bootstrap file always enabled so it has been placed into the tests directory so it was always created. Now we disabled bootstrap by default so dir is not created... Anyway, this should be fixed

Member

DavertMik commented May 25, 2017

Looks like a regression of 2.3
Before 2.3 we had bootstrap file always enabled so it has been placed into the tests directory so it was always created. Now we disabled bootstrap by default so dir is not created... Anyway, this should be fixed

@DavertMik DavertMik added the BUG label May 25, 2017

@DavertMik DavertMik self-assigned this May 25, 2017

DavertMik added a commit that referenced this issue May 25, 2017

@DavertMik DavertMik closed this in #4254 May 26, 2017

DavertMik added a commit that referenced this issue May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment