New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleContainer::includeMethodAsAction $module::$excludeActions is optional #4381

Closed
CactusCoder opened this Issue Jul 4, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@CactusCoder
Contributor

CactusCoder commented Jul 4, 2017

What are you trying to achieve?

Call includeMethodAsAction() on a controller without an $excludeActions property.

What do you get instead?

Fatal error.

Provide console output if related. Use -vvv mode for more details.

PHP Fatal error:  Uncaught Error: Access to undeclared static property: Codeception\Extension\Recorder::$excludeActions in phar:///usr/local/bin/codecept/src/Codeception/Lib/ModuleContainer.php:164

Provide test source code if related

// paste test

Details

First line in ModuleContainer::includeMethodAsAction should check for existence of $module::$excludeActions before accessing it.

  • Codeception version:
    2.3
  • PHP Version:
  • Operating System:
  • Installation type: Phar || Composer
  • List of installed packages (composer show)
  • Suite configuration:
# paste suite config here
@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Jul 4, 2017

Member

Please make a pull request.

Member

Naktibalda commented Jul 4, 2017

Please make a pull request.

@CactusCoder

This comment has been minimized.

Show comment
Hide comment
@CactusCoder

CactusCoder Jul 4, 2017

Contributor

I'll have to learn how to do this - will be back.

Contributor

CactusCoder commented Jul 4, 2017

I'll have to learn how to do this - will be back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment