Add Environment Name To Descriptor Unique Signatures #5294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add the current environment name to unique signatures - closes Codeception/phpunit-wrapper#4
Naktibalda
reviewed
Dec 14, 2018
Issue: Codeception/phpunit-wrapper#4 - initialise $env and $example as empty strings - keep empty string values for concatenation if there's no scenario or example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Codeception/phpunit-wrapper#4
When running tests using multiple environments in serial, i.e.
Test descriptor function
getTestSignatureUnique()does not return unique signatures across environments. Features using the unique signature (e.g. the phpunit-wrapper html report) can then conflate the tests.In the case of the html report this causes a test that fails for an environment to appear as failed in the report for subsequent environments, even if it passes in those other environments.
Fixed by adding the test case's environment name to the unique signature.