New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load firefox profile from suite config. #1403

Merged
merged 3 commits into from Sep 27, 2014

Conversation

Projects
None yet
2 participants
@pablopaul
Contributor

pablopaul commented Sep 17, 2014

Load firefox profile from suite config #1193.

Show outdated Hide outdated src/Codeception/Module/WebDriver.php
@@ -93,6 +94,9 @@ public function _initialize()
$this->wd_host = sprintf('http://%s:%s/wd/hub', $this->config['host'], $this->config['port']);
$this->capabilities = $this->config['capabilities'];
$this->capabilities[\WebDriverCapabilityType::BROWSER_NAME] = $this->config['browser'];
if (!is_null($this->config['capabilities']['firefox_profile'])) {
$this->capabilities['firefox_profile'] = file_get_contents($this->config['capabilities']['firefox_profile']);

This comment has been minimized.

@DavertMik

DavertMik Sep 18, 2014

Member

what if file does not exists?
please throw a ModuleConfig Exception

@DavertMik

DavertMik Sep 18, 2014

Member

what if file does not exists?
please throw a ModuleConfig Exception

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Sep 18, 2014

Member

@pablopaul also take a note, that Travis is a bit upset by this PR. Please, make him green again )

Member

DavertMik commented Sep 18, 2014

@pablopaul also take a note, that Travis is a bit upset by this PR. Please, make him green again )

@pablopaul

This comment has been minimized.

Show comment
Hide comment
@pablopaul

pablopaul Sep 18, 2014

Contributor

@DavertMik thanks for the feedback, I am definitely going to check the travis error and will enhance the routine a little bit. Just after seeing that the Travis Tests are failing I realized I could run all the tests locally (as Travis does), maybe this is something we could add in "Contributing" readme section?!

Contributor

pablopaul commented Sep 18, 2014

@DavertMik thanks for the feedback, I am definitely going to check the travis error and will enhance the routine a little bit. Just after seeing that the Travis Tests are failing I realized I could run all the tests locally (as Travis does), maybe this is something we could add in "Contributing" readme section?!

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Sep 18, 2014

Member

It is in Readme of tests folder, check it out
18 вер. 2014 08:14, користувач "pablopaul" notifications@github.com
написав:

@DavertMik https://github.com/DavertMik thanks for the feedback, I am
definitely going to check the travis error and will enhance the routine a
little bit. Just after seeing that the Travis Tests are failing I realized
I could run all the tests locally (as Travis does), maybe this is something
we could add in "Contributing" readme section?!


Reply to this email directly or view it on GitHub
#1403 (comment)
.

Member

DavertMik commented Sep 18, 2014

It is in Readme of tests folder, check it out
18 вер. 2014 08:14, користувач "pablopaul" notifications@github.com
написав:

@DavertMik https://github.com/DavertMik thanks for the feedback, I am
definitely going to check the travis error and will enhance the routine a
little bit. Just after seeing that the Travis Tests are failing I realized
I could run all the tests locally (as Travis does), maybe this is something
we could add in "Contributing" readme section?!


Reply to this email directly or view it on GitHub
#1403 (comment)
.

Improve firefox profile loading.
Check given firefox profile for existence before setting it as WebDriver capability.
@pablopaul

This comment has been minimized.

Show comment
Hide comment
@pablopaul

pablopaul Sep 20, 2014

Contributor

@DavertMik Can you please review the code from the last commit, Travis Tests are still unhappy, but I think it is not related to my changes.

Contributor

pablopaul commented Sep 20, 2014

@DavertMik Can you please review the code from the last commit, Travis Tests are still unhappy, but I think it is not related to my changes.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Sep 27, 2014

Member

@pablopaul yes, thanks!

Member

DavertMik commented Sep 27, 2014

@pablopaul yes, thanks!

DavertMik added a commit that referenced this pull request Sep 27, 2014

Merge pull request #1403 from pablopaul/2.0
Load firefox profile from suite config.

@DavertMik DavertMik merged commit 998a618 into Codeception:2.0 Sep 27, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment