Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grabTextFrom doesn't work with regex #1519

Merged
merged 1 commit into from Nov 9, 2014

Conversation

@zbateson
Copy link
Member

@zbateson zbateson commented Nov 7, 2014

A change to the match() function returns an empty crawler rather than
null. Added a test for regex with grabTextFrom

Zaahid Bateson
A change to the match() function returns an empty crawler rather than
null.  Added a test for regex with grabTextFrom
@DavertMik
Copy link
Member

@DavertMik DavertMik commented Nov 9, 2014

Thanks. Looks like Travis passes it so I can finally merge. Sorry for the delay.
I really like it! The fix is clean and tests in it... Awesome!

DavertMik added a commit that referenced this pull request Nov 9, 2014
grabTextFrom doesn't work with regex
@DavertMik DavertMik merged commit 945482e into Codeception:2.0 Nov 9, 2014
1 check was pending
1 check was pending
continuous-integration/travis-ci The Travis CI build is in progress
Details
@zbateson zbateson deleted the zbateson:grabTextFrom-with-regex branch Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.