Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding remote code coverage requests context configuration feature #1524

Merged
merged 2 commits into from Nov 13, 2014

Conversation

@synchrone
Copy link
Contributor

@synchrone synchrone commented Nov 7, 2014

Issue #1513 related feature

@synchrone synchrone force-pushed the synchrone:issue-1513-fix branch from 5b9dd75 to 75c8933 Nov 11, 2014
``` yaml
coverage:
remote_context_options:
timeout: 60

This comment has been minimized.

@DavertMik

DavertMik Nov 11, 2014
Member

please add http subsection to specify http-specific things. Optionally user can set ssl context configuration as well

@DavertMik
Copy link
Member

@DavertMik DavertMik commented Nov 11, 2014

@zbateson what do you think about it?
Looks like this PR takes up yours #1520 are you ok with it?

@zbateson
Copy link
Member

@zbateson zbateson commented Nov 11, 2014

That's excellent! Thanks @synchrone. Yes, I think having it as a configurable option is much better and this handles the issue I was trying to fix.

DavertMik added a commit that referenced this pull request Nov 13, 2014
Adding remote code coverage requests context configuration feature
@DavertMik DavertMik merged commit e44ab93 into Codeception:2.0 Nov 13, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
@synchrone
Copy link
Contributor Author

@synchrone synchrone commented Nov 13, 2014

Also resolves #1513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.