Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing matchOption to return the option value in case there is no value attribute #1663

Merged
merged 1 commit into from Jan 26, 2015

Conversation

@synchrone
Copy link
Contributor

@synchrone synchrone commented Jan 24, 2015

Sometimes HTML select element only has value like this, but not the "value" attribute. So we need to return the text, much like we match it initially.

@DavertMik
Copy link
Member

@DavertMik DavertMik commented Jan 26, 2015

Thanks

DavertMik added a commit that referenced this pull request Jan 26, 2015
Fixing matchOption to return the option value in case there is no value attribute
@DavertMik DavertMik merged commit 97d7c98 into Codeception:2.0 Jan 26, 2015
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
DavertMik added a commit that referenced this pull request Jan 26, 2015
@DavertMik
Copy link
Member

@DavertMik DavertMik commented Jan 26, 2015

Ok, I have issues with this PR so I made a patch for it

DavertMik added a commit that referenced this pull request Jan 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.