Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for undefined method Symfony\Component\HttpFoundation\Request::route() #1756

Merged
merged 1 commit into from Mar 2, 2015

Conversation

Projects
None yet
8 participants
@janhenkgerritsen
Copy link
Contributor

commented Mar 2, 2015

This is a fix for #1748, based on the fix proposed in #1750 by @jedrzej.

I confirmed the issue when I did a composer update on the sample application, and this commit fixes the issue.

@DavertMik

This comment has been minimized.

Copy link
Member

commented Mar 2, 2015

@janhenkgerritsen Thanks
If this fix is really important I can release 2.0.12 right now

DavertMik added a commit that referenced this pull request Mar 2, 2015

Merge pull request #1756 from janhenkgerritsen/2.0
Fix for undefined method Symfony\Component\HttpFoundation\Request::route()

@DavertMik DavertMik merged commit 4cc87c5 into Codeception:2.0 Mar 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@janhenkgerritsen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2015

@DavertMik it is an important fix, because the issue causes fatal errors even for default Laravel installations.

@ssfinney

This comment has been minimized.

Copy link

commented Mar 2, 2015

@DavertMik I can't get around this issue. Our team needs this fix.

@javichito

This comment has been minimized.

Copy link

commented Mar 4, 2015

Please we need the 2.0.12 release.

@carlituxman

This comment has been minimized.

Copy link

commented Mar 9, 2015

when the 2.0.12 release???

composer update install the 2.0.11

@janhenkgerritsen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2015

@DavertMik when can you release 2.0.12? I get a lot of complaints of Laravel users, not only here but also by email

@IsraelOrtuno

This comment has been minimized.

Copy link

commented Mar 10, 2015

We need this release, cannot test Laravel 5

@clockwork-coder

This comment has been minimized.

Copy link

commented Mar 10, 2015

Afraid I have to agree with the other posters here; it's been making our CI tests fail for over a week now, which really doesn't look good; workarounds are only good for local testing...

@janhenkgerritsen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2015

For everybody waiting for this release, I just updated the old Laravel5 module project you can find at https://github.com/janhenkgerritsen/codeception-laravel5. This now includes the fix for this error.

However, to make this work you should use a version of Codeception in your project that does not include the Laravel 5 module yet, otherwise the incorrect classes will be loaded. You should specify a version prior to 2.0.11, for example 2.0.10.1.

This is also a workaround, but one that should also work for CI tests.

@mabasic

This comment has been minimized.

Copy link

commented Mar 22, 2015

Waiting for 2.0.12 release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.