Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `packages` option for application packages. #1782

Merged
merged 1 commit into from Mar 23, 2015

Conversation

@jonathantorres
Copy link
Contributor

@jonathantorres jonathantorres commented Mar 16, 2015

Issue: #1783

@janhenkgerritsen
Copy link
Contributor

@janhenkgerritsen janhenkgerritsen commented Mar 20, 2015

I do not develop packages for Laravel 5, so could you please explain to me what the issue is that this change solves?

@jonathantorres
Copy link
Contributor Author

@jonathantorres jonathantorres commented Mar 20, 2015

Exactly as #1208 (you can still use the workbench on Laravel5 as a separate package)

When you run your main app tests you'll also want to run the tests on the packages. But since each package must have it's own codeception.yml file when the package tests are run, codeception tries to run the tests from it's own codeception.yml file and not from the main laravel app.

So I added another option to the module in which you can specify the directory in which you'll store your packages. (Since in laravel5 it can be any name, not necessary "workbench")

@DavertMik
Copy link
Member

@DavertMik DavertMik commented Mar 22, 2015

@janhenkgerritsen looks good to me. Should I merge?

@DavertMik DavertMik added the Laravel5 label Mar 22, 2015
@janhenkgerritsen
Copy link
Contributor

@janhenkgerritsen janhenkgerritsen commented Mar 23, 2015

Also looks good to me, so you can merge this.

DavertMik added a commit that referenced this pull request Mar 23, 2015
Add `packages` option for application packages.
@DavertMik DavertMik merged commit ade835f into Codeception:2.0 Mar 23, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DavertMik
Copy link
Member

@DavertMik DavertMik commented Mar 23, 2015

done. thank you!

@jonathantorres jonathantorres deleted the jonathantorres:packages branch Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.