Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phalcon1 DI #1967

Merged
merged 1 commit into from May 26, 2015
Merged

Phalcon1 DI #1967

merged 1 commit into from May 26, 2015

Conversation

@sergeyklay
Copy link
Member

@sergeyklay sergeyklay commented May 25, 2015

  • Improved dependency injector container check
  • Used short syntax for arrays

Important

  • Phalcon1::_after now uses isset($this->di['db']) instead $this->di->has('db') — in some cases di not initialized here (for example when test fails)
@sergeyklay
Copy link
Member Author

@sergeyklay sergeyklay commented May 25, 2015

@DavertMik Current 2.0 branch is broken? Why tests fails?

@DavertMik
Copy link
Member

@DavertMik DavertMik commented May 25, 2015

Yeah, some stupid MySQL test :(
I will fix those test and merge valid PRs afterwards

Thanks for waiting

@DavertMik
Copy link
Member

@DavertMik DavertMik commented May 26, 2015

Thanks, merging

DavertMik added a commit that referenced this pull request May 26, 2015
Phalcon1 DI
@DavertMik DavertMik merged commit c362e5b into Codeception:2.0 May 26, 2015
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer 1 new issues
Details
@DavertMik DavertMik added the Phalcon label May 26, 2015
@sergeyklay sergeyklay deleted the sergeyklay:fix_phalcon_1 branch May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.