Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoted table name in Db::select, removed identical methods from child classes #2231

Merged

Conversation

@Naktibalda
Copy link
Member

@Naktibalda Naktibalda commented Jul 31, 2015

Use getQuotedName() for escaping table name in DB Driver's select().
Set default quotes to double quotes.
Select methods of some implementation classes became identical to DB::select after this change, so I removed them.
Also I removed deleteQuery from SqlSrv, because it became identical to DB::deleteQuery after earlier change.

@sergeyklay sergeyklay closed this Jul 31, 2015
@sergeyklay sergeyklay reopened this Jul 31, 2015
Naktibalda added a commit that referenced this pull request Aug 1, 2015
Quoted table name in Db::select, removed identical methods from child classes
@Naktibalda Naktibalda merged commit 9af9b54 into Codeception:2.1 Aug 1, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
@Naktibalda Naktibalda deleted the Naktibalda:db-driver-select-table-quotes branch Aug 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.