Replacing explode functions with preg_split alternative #2548

Merged
merged 6 commits into from Nov 22, 2015

Conversation

Projects
None yet
2 participants
@niclopez
Contributor

niclopez commented Nov 17, 2015

Replacing explode functions with preg_split alternative.
#2501

niclopez added some commits Nov 17, 2015

Replacing explode functions with preg_split
Replacing "explode" function with "preg_split" alternatives allows to use all characters inside a regex pattern.
Merge pull request #1 from niclopez/issue-2535
Replacing explode functions with preg_split
@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Nov 17, 2015

Member

Could you add some tests to https://github.com/Codeception/Codeception/blob/2.1/tests/unit/Codeception/Util/JsonTypeTest.php to demonstrate the issue that your change fixes?

Member

Naktibalda commented Nov 17, 2015

Could you add some tests to https://github.com/Codeception/Codeception/blob/2.1/tests/unit/Codeception/Util/JsonTypeTest.php to demonstrate the issue that your change fixes?

niclopez added some commits Nov 18, 2015

Extend unit tests in testRegexFilter method
Extend unit tests in testRegexFilter() method of JsonTypeTest file. 
Issue #2501
Merge pull request #2 from niclopez/issue-2501
Extend unit tests in testRegexFilter method
@niclopez

This comment has been minimized.

Show comment
Hide comment
@niclopez

niclopez Nov 18, 2015

Contributor

Of course!

Some tests have been done. My proposed fix allows to pass them successfully.

Contributor

niclopez commented Nov 18, 2015

Of course!

Some tests have been done. My proposed fix allows to pass them successfully.

niclopez added some commits Nov 19, 2015

Naktibalda added a commit that referenced this pull request Nov 22, 2015

Merge pull request #2548 from niclopez/2.1
Replacing explode functions with preg_split alternative

@Naktibalda Naktibalda merged commit 93bf04c into Codeception:2.1 Nov 22, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment