New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memcache module: bug fix "memcache" extension init #2572

Merged
merged 2 commits into from Nov 25, 2015

Conversation

Projects
None yet
3 participants
@pfz
Contributor

pfz commented Nov 23, 2015

Prevent this from happening :
[PHPUnit_Framework_Exception]
MemcachePool::close(): No servers added to memcache connection

Memcache module: bug fix "memcache" extension init
Prevent this from happening : 
[PHPUnit_Framework_Exception]
  MemcachePool::close(): No servers added to memcache connection
@Naktibalda

This comment has been minimized.

Show comment
Hide comment
@Naktibalda

Naktibalda Nov 24, 2015

Member

Please close connection in _after.

Member

Naktibalda commented Nov 24, 2015

Please close connection in _after.

@pfz

This comment has been minimized.

Show comment
Hide comment
@pfz

pfz Nov 24, 2015

Contributor

added. Thanks for the review.

Contributor

pfz commented Nov 24, 2015

added. Thanks for the review.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Nov 25, 2015

Member

Wow, it was used actually!

Member

DavertMik commented Nov 25, 2015

Wow, it was used actually!

DavertMik added a commit that referenced this pull request Nov 25, 2015

Merge pull request #2572 from pfz/patch-1
Memcache module: bug fix "memcache" extension init

@DavertMik DavertMik merged commit 38e0c75 into Codeception:2.1 Nov 25, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pfz

This comment has been minimized.

Show comment
Hide comment
@pfz

pfz Nov 25, 2015

Contributor

indeed :)

Contributor

pfz commented Nov 25, 2015

indeed :)

@pfz pfz deleted the pfz:patch-1 branch Nov 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment