Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpBrowser::submitForm method enh. #258

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
1 participant
@Ragazzo
Copy link
Contributor

commented Apr 10, 2013

Added exception throw if form not found, and i made some formatting fix (changed tabs to spaces). This is PR for this issue #256.
Sorry for that i did not provide tests, i just got stuck with them, because when i run php codecept run then when it is turn of unit-tests some of them failing with php-error can not redeclare class.... i think it is because i already has full phpunit installed and it is in my include_path. But anyway i've tested compiled phar and when form does not exist exception was correctly thrown like this:

1) Couldn't test index page in Codeception\TestCase\Cest::testMySimpleApp
Codeception\Exception\TestRuntime: Form with selector: "#not-existing" was not found on given page.

so i think this one can be merged.

@Ragazzo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2013

will provide new PR.

@Ragazzo Ragazzo closed this Apr 10, 2013

@Ragazzo Ragazzo referenced this pull request Apr 10, 2013

Merged

PhpBrowser-submitForm-fix #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.