allow appendField to work with content editable div #2588

Merged
merged 5 commits into from Dec 16, 2015

Conversation

Projects
None yet
2 participants
@nsanden
Contributor

nsanden commented Nov 28, 2015

No description provided.

nsanden added some commits Nov 28, 2015

@nsanden

This comment has been minimized.

Show comment
Hide comment
@nsanden

nsanden Nov 28, 2015

Contributor

No idea why the test in the build is failing because its seeing the text "moonrisesunrise" instead of "sunrisemoonrise" like I get when i test locally. Any ideas?

ss

Contributor

nsanden commented Nov 28, 2015

No idea why the test in the build is failing because its seeing the text "moonrisesunrise" instead of "sunrisemoonrise" like I get when i test locally. Any ideas?

ss

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Nov 28, 2015

Member

This may be related to Selenium or Firefox version. Which version of Selenium Server do you use locally?

Member

DavertMik commented Nov 28, 2015

This may be related to Selenium or Firefox version. Which version of Selenium Server do you use locally?

@DavertMik DavertMik added the WebDriver label Nov 28, 2015

@nsanden

This comment has been minimized.

Show comment
Hide comment
@nsanden

nsanden Nov 28, 2015

Contributor

I'm using selenium-server-standalone-2.48.2 and Firefox 38.0.5

I see the build is using 2.42.2. I will see if I can downgrade (just to test).

Contributor

nsanden commented Nov 28, 2015

I'm using selenium-server-standalone-2.48.2 and Firefox 38.0.5

I see the build is using 2.42.2. I will see if I can downgrade (just to test).

@nsanden

This comment has been minimized.

Show comment
Hide comment
@nsanden

nsanden Nov 28, 2015

Contributor

Seems to be Firefox. Travis build is using 31.0esr and when I downgrade to that locally (regardless of selenium version) my test does fail.

Contributor

nsanden commented Nov 28, 2015

Seems to be Firefox. Travis build is using 31.0esr and when I downgrade to that locally (regardless of selenium version) my test does fail.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Nov 30, 2015

Member

You could press key "END" before entering keys into area, to ensure the caret is in the end

Member

DavertMik commented Nov 30, 2015

You could press key "END" before entering keys into area, to ensure the caret is in the end

nsanden added some commits Dec 4, 2015

@nsanden

This comment has been minimized.

Show comment
Hide comment
@nsanden

nsanden Dec 4, 2015

Contributor

Your END key idea worked great. When I add that in, the test passes fine (locally). Remove it, test fails. As expected.

Once again though, I'm stumped as to why Travis is failing.

I'm using exactly the same Firefox and Selenium versions. If I add in wait times, I can clearly see the test do exactly as I expect it to. Caret goes to end of div. Appends the text, etc.

Contributor

nsanden commented Dec 4, 2015

Your END key idea worked great. When I add that in, the test passes fine (locally). Remove it, test fails. As expected.

Once again though, I'm stumped as to why Travis is failing.

I'm using exactly the same Firefox and Selenium versions. If I add in wait times, I can clearly see the test do exactly as I expect it to. Caret goes to end of div. Appends the text, etc.

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 16, 2015

Member

Didn't work for me locally as well. I will try to play around to find a way to make this work for everyone.
Thanks

Member

DavertMik commented Dec 16, 2015

Didn't work for me locally as well. I will try to play around to find a way to make this work for everyone.
Thanks

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 16, 2015

Member

I tried different combinations but still not working on my firefox. Let's leave it as experimental feature and skip the test for now.

Member

DavertMik commented Dec 16, 2015

I tried different combinations but still not working on my firefox. Let's leave it as experimental feature and skip the test for now.

DavertMik added a commit that referenced this pull request Dec 16, 2015

Merge pull request #2588 from nsanden/2.1
allow appendField to work with content editable div

@DavertMik DavertMik merged commit a4062c4 into Codeception:2.1 Dec 16, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 16, 2015

Member

Looks like I was using old Selenium Server 2.47. I think this should work fine on 2.48

Member

DavertMik commented Dec 16, 2015

Looks like I was using old Selenium Server 2.47. I think this should work fine on 2.48

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Dec 16, 2015

Member

Yes!

Member

DavertMik commented Dec 16, 2015

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment